Page History

...

Bug Fixes

The following fixes resolve problems visible to end users.

Fix bug when identifying existing peaks in a merge

If two separate footprints from the same catalog are merged due to an existing merged object which overlaps both of them the flags of which peaks are being detected were not being propagated. This issue caused apparent dropouts of sources and has now been fixed.

Fix situation in which the getChildren method of SourceCatalog may return the wrong information

The getChildren method requires that the result must be sorted by parent. This is naturally the case when the catalog is produced by detection or deblending tasks. However, if multiple catalogs are concatenated together this condition may no longer be true. The gitChildren method is updated to raise an exception if the precondition of sorting is not met.

HSC backport: Add tract conveniences

Added two new data id containers:

PerTractCcdDataIdContainer: determines the set of tracts each visit touches and adds a data reference with those tracts for each of the visit components.  This allows for the user to run a command line task forcedPhotCcd.py for a given visit without having to know which tracts overlap the visit. [Note this will also be used by meas_mosaic if/when it gets incorporated into the LSST stack.]

TractDataIdContainer: which generates a list of data references for patches within a given tract (effectively a "data reference list" that points to the entire tract). [Note that, at the time of writing, this is only being used by a qa analysis script currently under development.]

Correct bad default minInitialRadius for CModel

The minInitialRadius configuration parameter had a default that is too small, causing many galaxies to be fit with point source models, leading to bad star/galaxy classifications.

Bug Fixes

The following fixes resolve problems visible to end users.

Fix bug when identifying existing peaks in a merge

If two separate footprints from the same catalog are merged due to an existing merged object which overlaps both of them the flags of which peaks are being detected were not being propagated. This issue caused apparent dropouts of sources and has now been fixed.

Correct algebraic error in CModel uncertainty calculation

There was a simple but important algebra error in the uncertainty calculation, making the uncertainty a strong function of magnitude.

Fix situation in which the getChildren method of SourceCatalog may return the wrong information

The getChildren method requires that the result must be sorted by parent. This is naturally the case when the catalog is produced by detection or deblending tasks. However, if multiple catalogs are concatenated together this condition may no longer be true. The getChildren method was updated to raise an exception if the precondition of sorting is not met.

NaiveDipoleCentroid and NaiveDipoleFlux algorithms no longer require a centroid slot

Correct bad default minInitialRadius for CModel

The minInitialRadius configuration parameter had a default that is too small, causing many galaxies to be fit with point source models, leading to bad star/galaxy classificationsPreviously, initializing these algorithms was only possible if a centroid was already defined. That was not only unneccessary, but also made them more complicated to use, particularly in testing.

Update (some) example code to run with recent stack versions

Correct algebraic error in CModel uncertainty calculation

There was a simple but important algebra error in the uncertainty calculation, making the uncertainty a strong function of magnitudeChanges in afw::table had broken examples/calibrateTask.py in pipe_tasks. It has now been updated to comply with the latest afw::table API.

Fix a failure to appropriately log failed task execution

NaiveDipoleCentroid and NaiveDipoleFlux algorithms no longer require a centroid slot

Previously, initializing these algorithms was only possible if a centroid was already defined. That was not only unneccessary, but also made them more complicated to use, particularly in testing.When task execution fails, we add a message to the log (with level FATAL). In some cases, the very act of attempting to log this message could throw an exception, and information about the original error was lost. This has now been resolved.

Updates to Skymap packages

Update (some) example code to run with recent stack versions

Changes in afw::table had broken examples/calibrateTask.py in pipe_tasks. It has now been updated to comply with the latest afw::table APIAdd functions to return patches and tracts which contain given coordinates, i.e. conversions between celestial coordinates and tract,patch indicies. Functions include findClosestTractPatchList, findAllTract, and findTractPatchList which finds the closets tract and patch that overlaps coordinates, finds all tracts which include the specified coordinate, and finds tracts and patches that overlap a region respectively.

Port bug in meas_extensions_shapeHSM from HSC to LSST

Various bug fixes to the shapeHSM measurement algorithm were ported and include:

• Ensuring masks have same xy0 as images
• Fixing scaling coefficient in ellipticity error when using distortion
• Provide appropriate mask for variance image when measuring median variance around object
• Change from standard deviation to variance in the sky value when calling GalSim hsm code, as required by GalSim
• Fixes to unit tests to comply with above changes, and the port from the HSC framework to the LSST framework

Fix a failure to appropriately log failed task execution

When task execution fails, we add a message to the log (with level FATAL). In some cases, the very act of attempting to log this message could throw an exception, and information about the original error was lost. This has now been resolved.

HSC backport: Add tract conveniences

Added two new data id containers:

PerTractCcdDataIdContainer: determines the set of tracts each visit touches and adds a data reference with those tracts for each of the visit components.  This allows for the user to run a command line task forcedPhotCcd.py for a given visit without having to know which tracts overlap the visit. [Note this will also be used by meas_mosaic if/when it gets incorporated into the LSST stack.]

...

Updates to Skymap packages

Add functions to return patches and tracts which contain given coordinates, i.e. conversions between celestial coordinates and tract,patch indicies. Functions include findClosestTractPatchList, findAllTract, and findTractPatchList which finds the closets tract and patch that overlaps coordinates, finds all tracts which include the specified coordinate, and finds tracts and patches that overlap a region respectively.

Port bug in meas_extensions_shapeHSM from HSC to LSST

Various bug fixes to the shapeHSM measurement algorithm were ported and include:

• Ensuring masks have same xy0 as images
• Fixing scaling coefficient in ellipticity error when using distortion
• Provide appropriate mask for variance image when measuring median variance around object
• Change from standard deviation to variance in the sky value when calling GalSim hsm code, as required by GalSim
• Fixes to unit tests to comply with above changes, and the port from the HSC framework to the LSST framework

Build and code improvements

...