Date Virtual meeting from 3 July to 10 July, 2014
The July meeting has two items to discuss:
- https://jira.lsstcorp.org/browse/DM-831 : Standards: should not shadow python built-in functions
A short description:
During a recent code review, we noticed that our python standards wiki page doesn't mention shadowing of built-in functions Python Built-ins. The context in the review was that id was used as a variable name in a class method. This ticket proposes adding it to the standards.
- https://jira.lsstcorp.org/browse/DM-811 : Changing the Python coding standard: == and != SHOULD be used when comparing to None
A short description:
Both of these changes to existing Standards have been reviewed for technical merit and approved by the SAT. It's now TCT's turn to review them based on their impacts upon cost and and schedule.
The goal is to come to a recommendation to present to the DM Project Manager and the DM Project Scientist who will take our recommendation under consideration when determining their mandate on these two Standards.
- Unknown User (robyn) comments: To open the discussion, IMHO, these changes to the DM Standards will neither impact the DM Project cost nor impact the DM Project Schedule. Contrary opinions to that position are solicited in order to provide a more meaty discussion. Otherwise, just go straight ahead and caste your vote.
- Mario commented on page: DM-831 Standards: should not shadow python built-in functions with stronger non-support for this proposal.
If you wish to be counted in the quorum but abstain from voting, please note 'abstain' in the voting column.
|Unknown User (robyn)|
|Unknown User (ciardi)|
|Unknown User (mfreemon)|
|Robert Lupton||Y||Y||I don't like DM-831, but it passed the SAT|
|Unknown User (xiuqin)|
Summary of the TCT non-decision:
Since the TCT couldn't even get a quorum for this meeting and vote, the TCT will not provide the DM PM, Jeff Kantor, nor the DM PS, Mario Juric, a considered opinion on the proposed Standards changes.
The TCT Chair hopes they will consider the earlier discussions noted on the individual JIRA Issues when rendering their judgement.
Post Meeting Email Thread on "TCT Non-Resolution on Standards Change requests":
Email posted to Jeff Kantor and Mario Juric on 23 July 2014:
Please inform the TCT and the SAT regarding your final decision so that we may effect whatever changes are necessary to the documents and provide guidance to the Developers.
Email posted from jeff Kantor on 25 July 2014:
OK, when Mario returns we will make a decision and inform the TCT, thanks!
Email posted from Jeff Kantor on 6 August 2014:
Email posted from Robyn on 17 August 2014:
- Standards: should not shadow python built-in functions
- Changing the Python coding standard: == and != SHOULD be used when comparing to None
Apologies for not catching this earlier.
Email posted from Mario Juric on 18 August 2014:
> Hello Jeff and Mario,
> I copied over to the TCT Meeting notes your final acceptance of the
> issues discussed in this email thread when I realized that you accepted
> a Sprint Naming Policy but not the two standards in question!
> * *Changing the Python coding standard: == and != SHOULD be used when
> comparing to None*
> Would you please review the SAT recommendation and the TCT comments
> noted in the attached email. And then provide your resolution for each
> proposed standard.
(though I still have deep reservations about the first one; not worth
another round of SAT discussions, though...).